netdev - Re: [PATCH net] ethtool: do not print warning for applications using legacy API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180102.215002.671661044941618104.davem@davemloft.net>
Date:   Tue, 02 Jan 2018 21:50:02 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     stephen@...workplumber.org
Cc:     decot@...glers.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] ethtool: do not print warning for applications
 using legacy API

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Fri, 29 Dec 2017 10:02:52 -0800

> From: Stephen Hemminger <stephen@...workplumber.org>
> 
> In kernel log ths message appears on every boot:
>  "warning: `NetworkChangeNo' uses legacy ethtool link settings API,
>   link modes are only partially reported"
> 
> When ethtool link settings API changed, it started complaining about
> usages of old API. Ironically, the original patch was from google but
> the application using the legacy API is chrome.

Chrome on my machine doesn't do this, FWIW...

> Linux ABI is fixed as much as possible. The kernel must not break it
> and should not complain about applications using legacy API's.
> This patch just removes the warning since using legacy API's
> in Linux is perfectly acceptable.
> 
> Fixes: 3f1ac7a700d0 ("net: ethtool: add new ETHTOOL_xLINKSETTINGS API")
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>

Applied and queued up for -stable.