netdev - [PATCH] RDS: null pointer dereference in rds_atomic_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a4d45ce.8b8a1c0a.1d072.e5e1@mx.google.com>
Date:   Wed,  3 Jan 2018 21:06:06 +0000
From:   simo.ghannam@...il.com
To:     netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        santosh.shilimkar@...cle.com, davem@...emloft.net,
        rds-devel@....oracle.com
Cc:     Mohamed Ghannam <simo.ghannam@...il.com>
Subject: [PATCH] RDS: null pointer dereference in rds_atomic_free_op

From: Mohamed Ghannam <simo.ghannam@...il.com>

set rm->atomic.op_active to 0 when rds_pin_pages() fails
or the user supplied address is invalid,
this prevents a NULL pointer usage in rds_atomic_free_op()

Signed-off-by: Mohamed Ghannam <simo.ghannam@...il.com>
---
 net/rds/rdma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index bc2f1e0977d6..398932fbaf27 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -874,6 +874,7 @@ int rds_cmsg_atomic(struct rds_sock *rs, struct rds_message *rm,
 err:
 	if (page)
 		put_page(page);
+	rm->atomic.op_active = 0;
 	kfree(rm->atomic.op_notifier);
 
 	return ret;
-- 
2.14.1