netdev - RE: [PATCH v4 net-next 0/4] qed*: Advance to FW 8.33.1.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY1PR0701MB1337F7E67D0DE039C488FF39901E0@CY1PR0701MB1337.namprd07.prod.outlook.com>
Date:   Wed, 3 Jan 2018 07:32:29 +0000
From:   "Elior, Ariel" <Ariel.Elior@...ium.com>
To:     David Miller <davem@...emloft.net>,
        "Tayar, Tomer" <Tomer.Tayar@...ium.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: RE: [PATCH v4 net-next 0/4] qed*: Advance to FW 8.33.1.0

> From: Tomer Tayar <Tomer.Tayar@...ium.com>
> Date: Wed, 27 Dec 2017 19:30:04 +0200
> 
> > This series advances all qed* drivers to use firmware 8.33.1.0 which brings
> > new capabilities and initial support of new HW. The changes are mostly in
> > qed, and include changes in the FW interface files, as well as updating the
> > FW initialization and debug collection code. The protocol drivers have
> > minor functional changes for this firmware.
> >
> > Patch 1 Rearranges and refactors the FW interface files in preparation of
> > the new FW (no functional change).
> > Patch 2 Prepares the code for support of new HW (no functional change).
> > Patch 3 Actual utilization of the new FW.
> > Patch 4 Advances drivers' version.
> >
> > v3->v4:
> > Fix a compilation issue which was reported by krobot (dependency on CRC8).
> >
> > v2->v3:
> > Resend the series with a fixed title in the cover letter.
> >
> > v1->v2:
> > - Break the previous single patch into several patches.
> > - Fix compilation issues which were reported by krobot.
> 
> I'm going to apply this, however....
> 
> These firmware update changes are rediculously invasive.
> 
> Backporting patches through these updates will be a giant task if not
> impossible for anyone who tries to do something like this.
> 
> Who reviewed these changes outside of Cavium to look for clerical
> and typographical errors?  I be nobody did.  I personally scanned
> them for about 20 minutes.
> 
> Therefore, it is my judgment that the way firmware support updates are
> done in the QED driver is detrimental to it's long term
> maintainability.
> 
> Thank you.

Hi Dave,
We fully understand the concern regarding the size/depth of these changes,
and the difficulty of getting them reviewed, etc. Hopefully, this is the last time
you will see such massive changes. Future FW upgrades are expected to be far
lighter in their impact on the code. We also plan to make them more
frequent, which will further reduce the size/invasiveness of each change.
Thanks, and appreciate your time spent on reviewing this.
Ariel