netdev - Re: [PATCH net-next] net: mdio: Only perform gpio reset for PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWrGUgYvzP1jQUBRZmr46mn369vEsv5ZrG2Hgf7ZVLraw@mail.gmail.com>
Date:   Wed, 3 Jan 2018 09:36:09 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        sean.wang@...iatek.com,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: mdio: Only perform gpio reset for PHYs

Hi Andrew,

On Tue, Jan 2, 2018 at 5:40 PM, Andrew Lunn <andrew@...n.ch> wrote:
> Ethernet switch on the MDIO bus have historically performed their own
> handling of the GPIO reset line. The resent patch to have the MDIO
> core handle the reset has broken the switch drivers, in that they
> cannot claim the GPIO. Some switch drivers need more control over the
> GPIO line than what the MDIO core provides. So restore the historical
> behaviour by only performing a reset of PHYs, not switches.

Thanks for looking into this, and fixing it!

> Fixes: bafbdd527d56 ("phylib: Add device reset GPIO support")
> Reported-by: Sean Wang <sean.wang@...iatek.com>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

For PHY reset (not switches!):
Tested-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds