netdev - Re: [PATCH net-next] net: sched: fix tcf_block_get_ext() in case CONFIG_NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d6a9fe2-f1e2-116e-3f39-e81877db4cf3@netronome.com>
Date:   Thu, 4 Jan 2018 09:59:57 +0000
From:   Quentin Monnet <quentin.monnet@...ronome.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        oss-drivers@...ronome.com, Jiri Pirko <jiri@...nulli.us>,
        Alexander Aring <aring@...atatu.com>
Subject: Re: [PATCH net-next] net: sched: fix tcf_block_get_ext() in case
 CONFIG_NET_CLS is not set

Hi Cong,

2018-01-03 18:08 UTC-0800 ~ Cong Wang <xiyou.wangcong@...il.com>
> On Wed, Jan 3, 2018 at 5:30 PM, Jakub Kicinski
> <jakub.kicinski@...ronome.com> wrote:
>> From: Quentin Monnet <quentin.monnet@...ronome.com>
>>
>> The definition of functions tcf_block_get() and tcf_block_get_ext()
>> depends of CONFIG_NET_CLS being set. When those functions gained extack
>> support, only one version of the declaration of those functions was
>> updated. Function tcf_block_get() was later fixed with commit
>> 3c1490913f3b ("net: sch: api: fix tcf_block_get").
>>
>> Change arguments of tcf_block_get_ext() for the case when CONFIG_NET_CLS
>> is not set.
> 
> There is one already:
> https://patchwork.kernel.org/patch/10130849/
> 

Thanks! But this patch is the one I mentioned in the commit log: it
fixes a different function, tcf_block_get(). My patch is an additional
fix for tcf_block_get_ext().

Best regards,
Quentin