netdev - Re: [PATCH net-next 3/4] l2tp: remove configurable payload offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f985bb7-da3b-7792-a83f-cdbd3061a368@katalix.com>
Date:   Thu, 4 Jan 2018 12:36:26 +0000
From:   James Chapman <jchapman@...alix.com>
To:     Guillaume Nault <g.nault@...halink.fr>
Cc:     netdev@...r.kernel.org, lorenzo.bianconi@...hat.com,
        liuhangbin@...il.com
Subject: Re: [PATCH net-next 3/4] l2tp: remove configurable payload offset

On 04/01/18 10:25, Guillaume Nault wrote:
>> diff --git a/net/l2tp/l2tp_debugfs.c b/net/l2tp/l2tp_debugfs.c
>> index eb69411..2c30587 100644
>> --- a/net/l2tp/l2tp_debugfs.c
>> +++ b/net/l2tp/l2tp_debugfs.c
>> @@ -180,8 +180,8 @@ static void l2tp_dfs_seq_session_show(struct seq_file *m, void *v)
>>  		   session->lns_mode ? "LNS" : "LAC",
>>  		   session->debug,
>>  		   jiffies_to_msecs(session->reorder_timeout));
>> -	seq_printf(m, "   offset %hu l2specific %hu/%hu\n",
>> -		   session->offset, session->l2specific_type, session->l2specific_len);
>> +	seq_printf(m, "   offset 0 l2specific %hu/%hu\n",
>> +		   session->l2specific_type, session->l2specific_len);
>>
> Can't we drop "offset" completely?

That would change the debugfs file layout. If we remove it, we should
also update the header line which is in the debugs output and is
intended to indicate the layout of data.

James