netdev - Re: [patch net-next v4 00/10] net: sched: allow qdiscs to share filter block instances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8213e2c4-d715-cbca-5933-fc8ac11df764@mojatatu.com>
Date:   Thu, 4 Jan 2018 10:42:43 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Jakub Kicinski <kubakici@...pl>, David Ahern <dsahern@...il.com>,
        netdev@...r.kernel.org, davem@...emloft.net,
        xiyou.wangcong@...il.com, mlxsw@...lanox.com, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com,
        michael.chan@...adcom.com, ganeshgr@...lsio.com,
        saeedm@...lanox.com, matanb@...lanox.com, leonro@...lanox.com,
        idosch@...lanox.com, simon.horman@...ronome.com,
        pieter.jansenvanvuuren@...ronome.com, john.hurley@...ronome.com,
        alexander.h.duyck@...el.com, ogerlitz@...lanox.com,
        john.fastabend@...il.com, daniel@...earbox.net
Subject: Re: [patch net-next v4 00/10] net: sched: allow qdiscs to share
 filter block instances

On 18-01-04 09:06 AM, Jiri Pirko wrote:
> Thu, Jan 04, 2018 at 02:43:08PM CET, jhs@...atatu.com wrote:

>> If i understood you correctly,  that is still iffy.
>> An admin will see packets for the same filter on one device going
>> to an agreed-to queue but on another going to a default queue.
> 
> Yeah, it is. That needs a bit more thoughts and discussion. That was the
> main purpose I did not address it in this patchset and allowed only
> ingress and clsact qidsc.
> 

Like i said - this requires the admin to be aware of this issue.
It is nasty otherwise.

>> One option is to name all egress queues the same way on all devices
>> f.e in the two examples i provided call root qdiscs 1:0.
>>
>> I am not sure how cleanly you get this to work with egress
>> My current thinking involves some brain somersault...
>> I will think some more about it...
> 
> clsact egress works the same as ingress qdisc - please check the code.
> 


clsact egress does not deal with tcf_result - what code do you want
me to check?

cheers,
jamal