netdev - Re: [PATCH net] net: stmmac: enable EEE in MII, GMII or RGMII only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180104.140226.949194351555593980.davem@davemloft.net>
Date:   Thu, 04 Jan 2018 14:02:26 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jbrunet@...libre.com
Cc:     netdev@...r.kernel.org, peppe.cavallaro@...com,
        alexandre.torgue@...com, linux-kernel@...r.kernel.org,
        linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH net] net: stmmac: enable EEE in MII, GMII or RGMII only

From: Jerome Brunet <jbrunet@...libre.com>
Date: Wed,  3 Jan 2018 16:46:29 +0100

> Note in the databook - Section 4.4 - EEE :
> " The EEE feature is not supported when the MAC is configured to use the
> TBI, RTBI, SMII, RMII or SGMII single PHY interface. Even if the MAC
> supports multiple PHY interfaces, you should activate the EEE mode only
> when the MAC is operating with GMII, MII, or RGMII interface."
> 
> Applying this restriction solves a stability issue observed on Amlogic
> gxl platforms operating with RMII interface and the internal PHY.
> 
> Fixes: 83bf79b6bb64 ("stmmac: disable at run-time the EEE if not supported")
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
> Tested-by: Arnaud Patard <arnaud.patard@...-net.org>

Applied and queued up for -stable, thanks.