netdev - Re: [PATCH] sh_eth: fix TSU resource handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180104.141835.1836351687367008943.davem@davemloft.net>
Date:   Thu, 04 Jan 2018 14:18:35 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sergei.shtylyov@...entembedded.com
Cc:     netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-sh@...r.kernel.org, nobuhiro.iwamatsu.yj@...esas.com
Subject: Re: [PATCH] sh_eth: fix TSU resource handling

From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Wed, 03 Jan 2018 20:09:49 +0300

> When switching  the driver to the managed device API,  I managed to break
> the  case of a  dual Ether devices sharing a single TSU: the 2nd Ether port
> wouldn't probe. Iwamatsu-san has tried to fix this but his patch was buggy
> and he then dropped the ball...
> 
> The solution is to  limit calling devm_request_mem_region() to the first
> of  the two  ports  sharing the same TSU, so devm_ioremap_resource() can't
> be used anymore for the TSU resource...
> 
> Fixes: d5e07e69218f ("sh_eth: use managed device API")
> Reported-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

Applied and queued up for -stable, thanks.