netdev - Re: [PATCH RESEND] bpf: fix bad include in libbpf when srctree is set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe6b4559-0f74-d2d8-d4f7-349e0477aff5@iogearbox.net>
Date:   Thu, 4 Jan 2018 23:47:57 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Alexander Alemayhu <alexander@...mayhu.com>
Cc:     netdev@...r.kernel.org, alexei.starovoitov@...il.com,
        acme@...hat.com
Subject: Re: [PATCH RESEND] bpf: fix bad include in libbpf when srctree is set

On 01/01/2018 01:36 PM, Alexander Alemayhu wrote:
> The relative path can be wrong and prevents the build.

You mean if you move the files from tools/lib/bpf/ to a different
location, and then specify srctree var pointing to a kernel tree?

I think this would also break various other assumptions inside the
tools/lib/bpf/Makefile, e.g. the uapi header checks also depending
on relative paths.

> 	Makefile:57: ../../scripts/Makefile.include: No such file or directory
> 	make: *** No rule to make target '../../scripts/Makefile.include'.  Stop.
> 
> Signed-off-by: Alexander Alemayhu <alexander@...mayhu.com>
> ---
>  tools/lib/bpf/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
> index 4555304dc18e..0068829a56db 100644
> --- a/tools/lib/bpf/Makefile
> +++ b/tools/lib/bpf/Makefile
> @@ -54,7 +54,7 @@ man_dir_SQ = '$(subst ','\'',$(man_dir))'
>  export man_dir man_dir_SQ INSTALL
>  export DESTDIR DESTDIR_SQ
>  
> -include ../../scripts/Makefile.include
> +include $(srctree)/tools/scripts/Makefile.include
>  
>  # copy a bit from Linux kbuild
>  
>