netdev - Re: [PATCH net-next 06/20] net: hns3: Modify the update period of packet statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180105145405.GC4038@lunn.ch>
Date:   Fri, 5 Jan 2018 15:54:05 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Peng Li <lipeng321@...wei.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        salil.mehta@...wei.com
Subject: Re: [PATCH net-next 06/20] net: hns3: Modify the update period of
 packet statistics

> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> @@ -1126,6 +1126,7 @@ static int hns3_nic_set_features(struct net_device *netdev,
>  {
>  	struct hns3_nic_priv *priv = netdev_priv(netdev);
>  	int queue_num = priv->ae_handle->kinfo.num_tqps;
> +	struct hnae3_handle *handle = priv->ae_handle;
>  	struct hns3_enet_ring *ring;
>  	unsigned int start;
>  	unsigned int idx;
> @@ -1134,6 +1135,8 @@ static int hns3_nic_set_features(struct net_device *netdev,
>  	u64 tx_pkts = 0;
>  	u64 rx_pkts = 0;
>  
> +	handle->ae_algo->ops->update_stats(handle, &netdev->stats);
> +
>  	for (idx = 0; idx < queue_num; idx++) {
>  		/* fetch the tx stats */
>  		ring = priv->ring_data[idx].ring;

There is something odd going on with patch here. Notice how it says
hns3_nic_set_features(). This is not the function being patched, it is
actually the next one, hns3_nic_get_stats64(), which makes a lot more
sense.

Is it because the static void is on the previous line?

It would be nice if the function was correctly reported. It makes it
easier to review the patch.

       Andrew