netdev - Re: [PATCH net-next 0/4] l2tp: remove configurable offset parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180105.110405.1664216604559089965.davem@davemloft.net>
Date:   Fri, 05 Jan 2018 11:04:05 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     g.nault@...halink.fr
Cc:     jchapman@...alix.com, netdev@...r.kernel.org,
        lorenzo.bianconi@...hat.com, liuhangbin@...il.com
Subject: Re: [PATCH net-next 0/4] l2tp: remove configurable offset
 parameters

From: Guillaume Nault <g.nault@...halink.fr>
Date: Thu, 4 Jan 2018 11:32:28 +0100

> On Wed, Jan 03, 2018 at 10:48:03PM +0000, James Chapman wrote:
>> This patch series removes all code to support a configurable offset in
>> transmitted l2tp packets. Code to handle this is incomplete and buggy
>> and has been this way for years. If anyone tried to configure an
>> offset, it would be ignored for L2TPv2 tunnels, or for L2TPv3 tunnels,
>> could result in L2TPv3 packets being transmitted which are not
>> compliant with L2TPv3 RFC3931. This patch series removes the support
>> for configurable offsets.
>> 
> Thanks for the detailed cover letter!
> 
> There are a few more places talking about offsets:
>   * Description of SESSION_CREATE in include/uapi/linux/l2tp.h.
>   * Description of L2TPv3 packet format above l2tp_recv_common() in
>     net/l2tp/l2tp_core.c.
> 
> I can submit a followup patch to remove them.
> 
> Reviewed-by: Guillaume Nault <g.nault@...halink.fr>
> Tested-by: Guillaume Nault <g.nault@...halink.fr>

Series applied, thanks everyone.