netdev - Re: [PATCH net-next 1/6] net: Fix netdev_WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180105.133519.1602365963790420581.davem@davemloft.net>
Date:   Fri, 05 Jan 2018 13:35:19 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     galp@...lanox.com
Cc:     netdev@...r.kernel.org, tariqt@...lanox.com, saeedm@...lanox.com
Subject: Re: [PATCH net-next 1/6] net: Fix netdev_WARN_ONCE macro

From: Gal Pressman <galp@...lanox.com>
Date: Thu,  4 Jan 2018 16:55:58 +0200

> netdev_WARN_ONCE is broken (whoops..), fix it.

You don't say how it is broken and how you are fixing that
brokenness, and you must do this.

Yes, if I stare at your patch for a few minutes I can see
the missing "," but you could have saved everyone reviewing
this patch (now and in the future) by writing a proper and
complete commit message.