netdev - Re: [PATCH net-next 0/2] rds: use RCU between work-enqueue and connection teardown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180105.133935.340079689611117850.davem@davemloft.net>
Date:   Fri, 05 Jan 2018 13:39:35 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sowmini.varadhan@...cle.com
Cc:     netdev@...r.kernel.org, rds-devel@....oracle.com,
        santosh.shilimkar@...cle.com
Subject: Re: [PATCH net-next 0/2] rds: use RCU between work-enqueue and
 connection teardown

From: Sowmini Varadhan <sowmini.varadhan@...cle.com>
Date: Thu,  4 Jan 2018 06:52:58 -0800

> This patchset follows up on the root-cause mentioned in
> https://www.spinics.net/lists/netdev/msg472849.html
> 
> Patch1 implements some code refactoring that was suggeseted
> as an enhancement in http://patchwork.ozlabs.org/patch/843157/
> It replaces the c_destroy_in_prog bit in rds_connection with 
> an atomically managed flag in rds_conn_path.
> 
> Patch2 builds on Patch1 and uses RCU to make sure that 
> work is only enqueued if the connection destroy is not already
> in progress: the test-flag-and-enqueue is done under rcu_read_lock,
> while destroy first sets the flag, uses synchronize_rcu to 
> wait for existing reader threads to complete, and then starts
> all the work-cancellation.
> 
> Since I have not been able to reproduce the original stack traces
> reported by syszbot, and these are fixes for a race condition that
> are based on code-inspection I am not marking these as reported-by 
> at this time.

Series applied, thank you.