netdev - Re: [Intel-wired-lan] [bpf-next V4 PATCH 03/14] i40e: setup xdp_rxq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aeac85ab-4b22-4cda-1f1c-5c3493454448@gmail.com>
Date:   Thu, 4 Jan 2018 20:17:05 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>,
        Daniel Borkmann <borkmann@...earbox.net>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Paul Menzel <pmenzel@...gen.mpg.de>, netdev@...r.kernel.org,
        dsahern@...il.com, intel-wired-lan@...ts.osuosl.org,
        gospo@...adcom.com, bjorn.topel@...el.com,
        michael.chan@...adcom.com
Subject: Re: [Intel-wired-lan] [bpf-next V4 PATCH 03/14] i40e: setup
 xdp_rxq_info

On 01/03/2018 02:25 AM, Jesper Dangaard Brouer wrote:
> The i40e driver has a special "FDIR" RX-ring (I40E_VSI_FDIR) which is
> a sideband channel for configuring/updating the flow director tables.
> This (i40e_vsi_)type does not invoke XDP-ebpf code.
> 
> As suggested by Björn (V2): Instead of marking this I40E_VSI_FDIR RX-ring
> a special case, reverse the logic and only select RX-rings of type
> I40E_VSI_MAIN to register xdp_rxq_info's for.
> 
> Driver hook points for xdp_rxq_info:
>  * reg  : i40e_setup_rx_descriptors (via i40e_vsi_setup_rx_resources)
>  * unreg: i40e_free_rx_resources    (via i40e_vsi_free_rx_resources)
> 
> Tested on actual hardware with samples/bpf program.
> 
> V2: Fixed bug in i40e_set_ringparam (memset zero) + match on I40E_VSI_MAIN.
> V4: Update patch desc that got out-of-sync with code.
> 
> Cc: intel-wired-lan@...ts.osuosl.org
> Cc: Björn Töpel <bjorn.topel@...el.com>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Cc: Paul Menzel <pmenzel@...gen.mpg.de>
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
> ---


Same here. LGTM.

Acked-by: John Fastabend <john.fastabend@...il.com>