netdev - Re: [PATCH 1/2] SolutionEngine771x: fix Ether platform data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85bfc811-4eaf-1140-4452-57542c3c8c3e@cogentembedded.com>
Date:   Sat, 6 Jan 2018 21:13:59 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>, linux-sh@...r.kernel.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] SolutionEngine771x: fix Ether platform data

Hello!

On 01/03/2018 11:08 PM, Sergei Shtylyov wrote:

> The 'sh_eth' driver's probe() method would fail  on the SolutionEngine7710
> board and crash on SolutionEngine7712 board  as the platform code is
> hopelessly behind the driver's platform data --  it passes the PHY address
> instead of 'struct sh_eth_plat_data *'; pass the latter to the driver in
> order to fix the bug...
> 
> Fixes: 71557a37adb5 ("[netdrvr] sh_eth: Add SH7619 support")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
[...]

    Now that I was finally able to build an SH kernel, I realized that I 
forgot to add #include <linux/sh_eth.h>... :-/

MBR, Sergei