netdev - Re: [PATCH 04/31] net: add support for ->poll_mask in proto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180106191622.GJ21978@ZenIV.linux.org.uk>
Date:   Sat, 6 Jan 2018 19:16:22 +0000
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Christoph Hellwig <hch@....de>
Cc:     Avi Kivity <avi@...lladb.com>, linux-aio@...ck.org,
        linux-fsdevel@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/31] net: add support for ->poll_mask in proto_ops

On Thu, Jan 04, 2018 at 09:00:16AM +0100, Christoph Hellwig wrote:
> The socket file operations still implement ->poll until all protocols are
> switched over.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  include/linux/net.h |  3 +++
>  net/socket.c        | 61 +++++++++++++++++++++++++++++++++++++++++++++++++----
>  2 files changed, 60 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/net.h b/include/linux/net.h
> index c2d468cb9821..94d65de30cb7 100644
> --- a/include/linux/net.h
> +++ b/include/linux/net.h
> @@ -147,6 +147,9 @@ struct proto_ops {
>  	int		(*getname)   (struct socket *sock,
>  				      struct sockaddr *addr,
>  				      int *sockaddr_len, int peer);
> +	void		(*pre_poll)  (const struct sock *sk);

Description?  Or more descriptive name, for that matter...

> +	__poll_t	(*poll_mask) (struct file *file, struct socket *sock,
> +				      __poll_t events);

Does that sucker need struct file?