netdev - Re: [PATCH iproute2] devlink, rdma, tipc: properly define TARGETS without HAVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180105163426.209e8f45@xeon-e3>
Date:   Fri, 5 Jan 2018 16:34:26 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Matthias Schiffer <mschiffer@...verse-factory.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] devlink, rdma, tipc: properly define TARGETS
 without HAVE_MNL

On Wed,  3 Jan 2018 16:28:52 +0100
Matthias Schiffer <mschiffer@...verse-factory.net> wrote:

> Leaving a variable with a generic name such as TARGETS undefined would lead
> to Make picking up its value from the environment. Avoid this by always
> defining TARGETS in the Makefiles.
> 
> Signed-off-by: Matthias Schiffer <mschiffer@...verse-factory.net>
> ---
> 
> I also noticed that many Makefiles refer to a variable LIBS, which is
> neither defined nor documented to be passed from the outside. Is this
> intentional?
> 
> 
>  devlink/Makefile | 4 +++-
>  rdma/Makefile    | 4 +++-
>  tipc/Makefile    | 4 +++-
>  3 files changed, 9 insertions(+), 3 deletions(-)

Applied.

Most of the Makefiles are very old.
There maybe other variable issues.