netdev - Re: [PATCH iproute2] ip fou: Pass family attribute as u8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180107122848.3f2121c1@xeon-e3>
Date:   Sun, 7 Jan 2018 12:28:48 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Filip Moc <dev@...6.cz>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] ip fou: Pass family attribute as u8

On Sun, 7 Jan 2018 15:28:13 +0100
Filip Moc <dev@...6.cz> wrote:

> This fixes fou on big-endian systems.
> 
> Signed-off-by: Filip Moc <dev@...6.cz>
> ---
>  ip/ipfou.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ip/ipfou.c b/ip/ipfou.c
> index febc2c8c..1f392ade 100644
> --- a/ip/ipfou.c
> +++ b/ip/ipfou.c
> @@ -52,7 +52,7 @@ static int fou_parse_opt(int argc, char **argv, struct nlmsghdr *n,
>  	__u8 ipproto, type;
>  	bool gue_set = false;
>  	int ipproto_set = 0;
> -	unsigned short family = AF_INET;
> +	__u8 family = AF_INET;
>  
>  	while (argc > 0) {
>  		if (!matches(*argv, "port")) {
> @@ -103,7 +103,7 @@ static int fou_parse_opt(int argc, char **argv, struct nlmsghdr *n,
>  
>  	addattr16(n, 1024, FOU_ATTR_PORT, port);
>  	addattr8(n, 1024, FOU_ATTR_TYPE, type);
> -	addattr16(n, 1024, FOU_ATTR_AF, family);
> +	addattr8(n, 1024, FOU_ATTR_AF, family);
>  
>  	if (ipproto_set)
>  		addattr8(n, 1024, FOU_ATTR_IPPROTO, ipproto);

How is this binary compatiable with older versions.