netdev - Re: [PATCH net-next v2 06/10] net/mlx5e: Change Mellanox references in DIM code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4de12484-6718-0926-e134-e9266dbcbe26@mellanox.com>
Date:   Sun, 7 Jan 2018 11:44:48 +0200
From:   Tal Gilboa <talgi@...lanox.com>
To:     Andy Gospodarek <andy@...yhouse.net>, netdev@...r.kernel.org
Cc:     mchan@...adcom.com, ogerlitz@...lanox.com,
        Andy Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net-next v2 06/10] net/mlx5e: Change Mellanox references
 in DIM code



On 1/6/2018 12:58 AM, Andy Gospodarek wrote:
> From: Andy Gospodarek <gospo@...adcom.com>
> 
> Change all appropriate mlx5_am* and MLX5_AM* references to net_dim and
> NET_DIM, respectively, in code that handles dynamic interrupt
> moderation.  Also change all references from 'am' to 'dim' when used as
> local variables.
> 
> Signed-off-by: Andy Gospodarek <gospo@...adcom.com>
> Acked-by: Tal Gilboa <talgi@...lanox.com>
> Acked-by: Saeed Mahameed <saeedm@...lanox.com>
> 
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/en.h       |  12 +-
>   drivers/net/ethernet/mellanox/mlx5/core/en_dim.c   |  14 +-
>   .../net/ethernet/mellanox/mlx5/core/en_ethtool.c   |  12 +-
>   drivers/net/ethernet/mellanox/mlx5/core/en_main.c  |  52 ++--
>   drivers/net/ethernet/mellanox/mlx5/core/en_rep.c   |   4 +-
>   drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c  |   2 +-
>   drivers/net/ethernet/mellanox/mlx5/core/net_dim.c  | 284 ++++++++++-----------
>   drivers/net/ethernet/mellanox/mlx5/core/net_dim.h  |  63 +++--
>   8 files changed, 232 insertions(+), 211 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> index 121f280..732f275 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> @@ -115,6 +115,9 @@
>   #define MLX5E_PARAMS_DEFAULT_MIN_RX_WQES                0x80
>   #define MLX5E_PARAMS_DEFAULT_MIN_RX_WQES_MPW            0x2
>   
> +#define MLX5E_CQ_PERIOD_MODE_START_FROM_EQE		0x0
> +#define MLX5E_CQ_PERIOD_MODE_START_FROM_CQE		0x1
> +

This enum should be defined under include/linux/mlx5/mlx5_ifc.h:
enum {
         MLX5_CQ_PERIOD_MODE_START_FROM_EQE = 0x0,
         MLX5_CQ_PERIOD_MODE_START_FROM_CQE = 0x1,
         MLX5_CQ_PERIOD_NUM_MODES
};

We already include this in the relevant files. This was changed in patch 
01/10, please revert.