netdev - Re: [RFC] memdup_user() and friends

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdhVam6aKovfWQ6RvsgVAbFsvodBy7SeeLxjdFxFSGjmQ@mail.gmail.com>
Date:   Mon, 8 Jan 2018 19:26:11 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux FS Devel <linux-fsdevel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [RFC] memdup_user() and friends

On Sun, Jan 7, 2018 at 4:16 AM, Al Viro <viro@...iv.linux.org.uk> wrote:

> What I propose is
>         * switch memdup_user() to GFP_USER
>         * add vmemdup_user(), using kvmalloc() instead of kmalloc() (also with
> GFP_USER)

Perhaps kvmemdup_user() for sake of consistency?

>         * switch open-coded instances of the latter to calling it
>         * switch some of the memdup_user() callers to vmemdup_user() - the ones that
> don't need physically contiguous copy and might be larger than a couple of pages.
>         * add apriori bounds on size in the call sites that do not have those yet -
> that'll require comments from maintainers of the code in question in some cases.
>
> Objections?

Not at all!

-- 
With Best Regards,
Andy Shevchenko