netdev - Re: wl1251: check return from call to wl1251_acx_arp_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180108174105.1C68E60314@smtp.codeaurora.org>
Date:   Mon,  8 Jan 2018 17:41:05 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Colin Ian King <colin.king@...onical.com>
Cc:     Pavel Machek <pavel@....cz>, Cong Wang <xiyou.wangcong@...il.com>,
        Johannes Berg <johannes.berg@...el.com>,
        "David S . Miller" <davem@...emloft.net>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: wl1251: check return from call to wl1251_acx_arp_ip_filter

Colin Ian King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently the less than zero error check on ret is incorrect
> as it is checking a far earlier ret assignment rather than the
> return from the call to wl1251_acx_arp_ip_filter. Fix this by
> adding in the missing assginment.
> 
> Detected by CoverityScan, CID#1164835 ("Logically dead code")
> 
> Fixes: 204cc5c44fb6 ("wl1251: implement hardware ARP filtering")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Patch applied to wireless-drivers-next.git, thanks.

ac1181c60822 wl1251: check return from call to wl1251_acx_arp_ip_filter

-- 
https://patchwork.kernel.org/patch/10133201/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches