netdev - Re: [RFC -next 2/2] net: sched: red: don't reset the backlog on every stat dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180108102317.1a08a7ee@cakuba.netronome.com>
Date:   Mon, 8 Jan 2018 10:23:17 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Nogah Frankel <nogahf@...lanox.com>
Cc:     "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        Yuval Mintz <yuvalm@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "oss-drivers@...ronome.com" <oss-drivers@...ronome.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>
Subject: Re: [RFC -next 2/2] net: sched: red: don't reset the backlog on
 every stat dump

On Mon, 8 Jan 2018 09:18:08 +0000, Nogah Frankel wrote:
> > Unlike for other statistics new_hw_stat < prev_hw_stat can be true.
> > Adjust mlxsw.  
> 
> There is one problem with this patch, and that is that we can fail in 
> changing RED that is offloaded. In this case, we delete RED from the driver
> but the backlog will still include the hardware backlog.
> The solution is to send in the offload-replace command a pointer to the
> backlog, so failure in updating the hardware can be follow by backlog update,
> if needed.

Thanks, will fix.