netdev - Re: [PATCH] doc: clarification about setting SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-+wqgfu+=b48Uart1gGf3nR7FsYEX8X-GisoOcmqzSJwQ@mail.gmail.com>
Date:   Tue, 9 Jan 2018 08:05:20 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Kornilios Kourtis <kou@...ich.ibm.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH] doc: clarification about setting SO_ZEROCOPY

On Tue, Jan 9, 2018 at 3:52 AM, Kornilios Kourtis <kou@...ich.ibm.com> wrote:
> Signed-off-by: Kornilios Kourtis <kou@...ich.ibm.com>

Acked-by: Willem de Bruijn <willemb@...gle.com>

Thanks, Kornilios.

> ---
>  Documentation/networking/msg_zerocopy.rst | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/networking/msg_zerocopy.rst b/Documentation/networking/msg_zerocopy.rst
> index 77f6d7e..c3380f4 100644
> --- a/Documentation/networking/msg_zerocopy.rst
> +++ b/Documentation/networking/msg_zerocopy.rst
> @@ -72,6 +72,10 @@ this flag, a process must first signal intent by setting a socket option:
>         if (setsockopt(fd, SOL_SOCKET, SO_ZEROCOPY, &one, sizeof(one)))
>                 error(1, errno, "setsockopt zerocopy");
>
> +Setting the socket option only works when the socket is in its initial
> +(TCP_CLOSED) state.  Trying to set the option for a socket returned by accept(),
> +for example, will lead to an EBUSY error. In this case, the option should be set
> +to the listening socket and it will be inherited by the accepted sockets.