[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20180109080326.000f603e@xeon-e3>
Date: Tue, 9 Jan 2018 08:03:26 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Antonio Quartulli <a@...table.cc>
Cc: netdev@...r.kernel.org, Stefano Brivio <sbrivio@...hat.com>
Subject: Re: [iproute2 1/2] ss: fix crash when skipping disabled header
field
On Sun, 7 Jan 2018 02:31:49 +0800
Antonio Quartulli <a@...table.cc> wrote:
> When the first header field is disabled (i.e. when passing the -t
> option), field_flush() is invoked with the `buffer` global variable
> still zero'd.
> However, in field_flush() we try to access buffer.cur->len
> during variables initialization, thus leading to a SIGSEGV.
>
> It's interesting to note that this bug appears only when the code
> is compiled with -O0, because the compiler is smart
> enough to immediately jump to the return statement if optimizations
> are enabled and skip the faulty instruction.
>
> Cc: Stefano Brivio <sbrivio@...hat.com>
> Cc: Stephen Hemminger <stephen@...workplumber.org>
> Signed-off-by: Antonio Quartulli <a@...table.cc>
Both applied, thanks.
Powered by blists - more mailing lists