netdev - Re: [PATCH net-next v4 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 09 Jan 2018 11:38:12 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jbaron@...mai.com
Cc:     mst@...hat.com, jasowang@...hat.com, netdev@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, qemu-devel@...gnu.org,
        virtio-dev@...ts.oasis-open.org
Subject: Re: [PATCH net-next v4 1/3] virtio_net: propagate linkspeed/duplex
 settings from the hypervisor

From: Jason Baron <jbaron@...mai.com>
Date: Fri,  5 Jan 2018 17:44:54 -0500

> The ability to set speed and duplex for virtio_net is useful in various
> scenarios as described here:
> 
> 16032be virtio_net: add ethtool support for set and get of settings
> 
> However, it would be nice to be able to set this from the hypervisor,
> such that virtio_net doesn't require custom guest ethtool commands.
> 
> Introduce a new feature flag, VIRTIO_NET_F_SPEED_DUPLEX, which allows
> the hypervisor to export a linkspeed and duplex setting. The user can
> subsequently overwrite it later if desired via: 'ethtool -s'.
> 
> Note that VIRTIO_NET_F_SPEED_DUPLEX is defined as bit 63, the intention
> is that device feature bits are to grow down from bit 63, since the
> transports are starting from bit 24 and growing up.
> 
> Signed-off-by: Jason Baron <jbaron@...mai.com>

Applied, thanks Jason.