netdev - Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <937b5edd-8b05-56db-5510-6d09b0004a0b@huawei.com>
Date:   Tue, 9 Jan 2018 10:48:04 +0800
From:   "lipeng (Y)" <lipeng321@...wei.com>
To:     David Miller <davem@...emloft.net>, <kubakici@...pl>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>, <salil.mehta@...wei.com>
Subject: Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

On 2018/1/9 9:54, David Miller wrote:
> From: Jakub Kicinski <kubakici@...pl>
> Date: Mon, 8 Jan 2018 17:50:21 -0800
>
>> Oh, I only noticed this extra misleading comment now.  Unless each queue
>> has a netdev, I don't see how these are per-queue.
> If it isn't per-queue I want this change reverted.

[patch 12/20 ] add statistics of netdev for ethtool -S, netdev may have 
multi queue.

As discussion here,  it is duplicate to add this patch.

I revert  [patch 12/20 ] , and then test on my board, HNS3 basic function and ethtool -S work well.

So I think it is OK if you can revert  [patch 12/20 ]("net: hns3: Add packet statistics of netdev").

Thanks
Peng Li

> .
>