netdev - Re: [PATCH bpf-next v2 00/14] nfp: bpf: relocations, verifier log, signed jumps and other updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e3fe91e-1bbb-a4bd-c73c-d9be00e4b897@iogearbox.net>
Date:   Wed, 10 Jan 2018 15:05:32 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Quentin Monnet <quentin.monnet@...ronome.com>,
        alexei.starovoitov@...il.com, netdev@...r.kernel.org
Cc:     oss-drivers@...ronome.com, jakub.kicinski@...ronome.com
Subject: Re: [PATCH bpf-next v2 00/14] nfp: bpf: relocations, verifier log,
 signed jumps and other updates

On 01/10/2018 01:25 PM, Quentin Monnet wrote:
> Jakub says:
> 
> Hi!
> 
> This series starts with a fix to Jesper's recent work, somehow I forgot
> about control rings during review.  Second patch is cleaning up a vNIC
> header, in kdoc we should not use @ for #define constants.  Aligning of
> the top of the stack as well as bottom (last bytes will be unused) helps
> the performance.  We should check offload datapath's max MTU when program
> is loaded and we can allow TC hw offload flag to be changed freely while
> XDP offload is active.
> 
> Next group of patches adds more fully featured relocation support.  Due
> to limited amount of code space we only load the image to NIC's memory
> when program is attached.  Since we can't predict which programs are
> loaded later, we should translate as if image was to be loaded at offset
> zero and only apply relocations at load time.  Many more advanced features
> (eg. tail class, subprograms, dynamic allocation of program space and
> sharing it between ports) will depend on this.
> 
> Nic adds support for signed comparison instructions.
> 
> Quentin makes use of the verifier log in our driver, the verifier print
> function (verbose()) has to be renamed and exported.
> 
> v2:
>  - replace #define by function aliasing for verbose() in patch 13

That's better, thanks for addressing the alias as well. Series applied
to bpf-next, thanks guys!