[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20180110083114.0bc55ae5@xeon-e3>
Date: Wed, 10 Jan 2018 08:31:14 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Christian Ehrhardt <christian.ehrhardt@...onical.com>
Cc: Netdev <netdev@...r.kernel.org>, Luca Boccassi <bluca@...ian.org>
Subject: Re: [PATCH iproute2 v2 0/2] tests: fix issues in autopkgtest
environment
On Wed, 10 Jan 2018 16:11:35 +0100
Christian Ehrhardt <christian.ehrhardt@...onical.com> wrote:
> Hi,
> while working on Debian bug [1] and the Ubuntu counterpart of it
> I found that the tests can throw a broken pipe warning.
>
> I kept the associated check-and-retry of the length separate to
> discuss the changes individually - feel free to squash them on
> commit if preferred.
>
> *Updates in v2*
> tag with --subject-prefix='PATCH iproute2' to trigger the right
> review queues in patchwork as requested by Luca Bocassi.
>
> [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=879854
>
> Christian Ehrhardt (2):
> tests: read limited amount from /dev/urandom
> tests: make sure rand_dev suffix has 6 chars
>
> testsuite/lib/generic.sh | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Looks good. Applied.
The method of generating a name seems a bit overly complex.
Maybe using something like pwgen would be easier.
Powered by blists - more mailing lists