netdev - Re: [PATCH net-next 3/3] l2tp: mark L2TP_ATTR_L2SPEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180110175903.GB1434@alphalink.fr>
Date:   Wed, 10 Jan 2018 18:59:03 +0100
From:   Guillaume Nault <g.nault@...halink.fr>
To:     Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, jchapman@...alix.com
Subject: Re: [PATCH net-next 3/3] l2tp: mark L2TP_ATTR_L2SPEC_LEN as not used

On Wed, Jan 10, 2018 at 06:20:42PM +0100, Lorenzo Bianconi wrote:
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
> ---
>  include/uapi/linux/l2tp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/l2tp.h b/include/uapi/linux/l2tp.h
> index 71e62795104d..ec609a017691 100644
> --- a/include/uapi/linux/l2tp.h
> +++ b/include/uapi/linux/l2tp.h
> @@ -97,7 +97,7 @@ enum {
>  	L2TP_ATTR_OFFSET,		/* u16 (not used) */
>  	L2TP_ATTR_DATA_SEQ,		/* u16 */
>  	L2TP_ATTR_L2SPEC_TYPE,		/* u8, enum l2tp_l2spec_type */
> -	L2TP_ATTR_L2SPEC_LEN,		/* u8, enum l2tp_l2spec_type */
> +	L2TP_ATTR_L2SPEC_LEN,		/* u8, (not used) */
> 
Nitpick: if you repost this series, you can remove the comma between 'u8'
and '(not used)' (to keep the format used by L2TP_ATTR_OFFSET).