netdev - Re: [PATCH net-next 1/4] ipv6: Calculate hash thresholds for IPv6 nexthops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5550c628-5014-427b-60c9-71cf80462723@gmail.com>
Date:   Tue, 9 Jan 2018 20:43:40 -0700
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...lanox.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, roopa@...ulusnetworks.com,
        nikolay@...ulusnetworks.com, pch@...bogen.com, jkbs@...hat.com,
        yoshfuji@...ux-ipv6.org, mlxsw@...lanox.com
Subject: Re: [PATCH net-next 1/4] ipv6: Calculate hash thresholds for IPv6
 nexthops

On 1/9/18 7:40 AM, Ido Schimmel wrote:
> Before we convert IPv6 to use hash-threshold instead of modulo-N, we
> first need each nexthop to store its region boundary in the hash
> function's output space.
> 
> The boundary is calculated by dividing the output space equally between
> the different active nexthops. That is, nexthops that are not dead or
> linkdown.
> 
> The boundaries are rebalanced whenever a nexthop is added or removed to
> a multipath route and whenever a nexthop becomes active or inactive.
> 
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> ---
>  include/net/ip6_fib.h   |  1 +
>  include/net/ip6_route.h |  7 ++++
>  net/ipv6/ip6_fib.c      |  8 ++---
>  net/ipv6/route.c        | 96 +++++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 106 insertions(+), 6 deletions(-)
> 

LGTM.
Acked-by: David Ahern <dsahern@...il.com>