netdev - Re: [Patch net] 8021q: fix a memory leak for VLAN 0 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180110.153127.366385711220396218.davem@davemloft.net>
Date:   Wed, 10 Jan 2018 15:31:27 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, dvyukov@...gle.com, vyasevich@...il.com,
        ben.hutchings@...ethink.co.uk
Subject: Re: [Patch net] 8021q: fix a memory leak for VLAN 0 device

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Tue,  9 Jan 2018 13:40:41 -0800

> A vlan device with vid 0 is allow to creat by not able to be fully
> cleaned up by unregister_vlan_dev() which checks for vlan_id!=0.
> 
> Also, VLAN 0 is probably not a valid number and it is kinda
> "reserved" for HW accelerating devices, but it is probably too
> late to reject it from creation even if makes sense. Instead,
> just remove the check in unregister_vlan_dev().
> 
> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> Fixes: ad1afb003939 ("vlan_dev: VLAN 0 should be treated as "no vlan tag" (802.1p packet)")
> Cc: Vlad Yasevich <vyasevich@...il.com>
> Cc: Ben Hutchings <ben.hutchings@...ethink.co.uk>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable, thanks.