netdev - Re: [PATCH net] nfp: always unmask aux interrupts at init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Jan 2018 15:51:22 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [PATCH net] nfp: always unmask aux interrupts at init

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Tue,  9 Jan 2018 18:14:28 -0800

> The link state and exception interrupts may be masked when we probe.
> The firmware should in theory prevent sending (and automasking) those
> interrupts if the device is disabled, but if my reading of the FW code
> is correct there are firmwares out there with race conditions in this
> area.  The interrupt may also be masked if previous driver which used
> the device was malfunctioning and we didn't load the FW (there is no
> other good way to comprehensively reset the PF).
> 
> Note that FW unmasks the data interrupts by itself when vNIC is
> enabled, such helpful operation is not performed for LSC/EXN interrupts.
> 
> Always unmask the auxiliary interrupts after request_irq().  On the
> remove path add missing PCI write flush before free_irq().
> 
> Fixes: 4c3523623dc0 ("net: add driver for Netronome NFP4000/NFP6000 NIC VFs")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>

Applied and queued up for -stable, thanks.