netdev - Re: [PATCH] net/9p: trans_xen: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0a=wAU_KSWd4Pu69yg7Ju3i5oyXd92n+MR=pc9Xesxqw@mail.gmail.com>
Date:   Wed, 10 Jan 2018 22:11:37 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Akemi Yagi <toracat@...epo.org>
Cc:     Networking <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net/9p: trans_xen: add missing MODULE_AUTHOR/DESCRIPTION/LICENSE

On Wed, Jan 10, 2018 at 6:27 PM, Akemi Yagi <toracat@...epo.org> wrote:
> On Wed, 10 Jan 2018 17:37:47 +0100, Arnd Bergmann wrote:
>>
>> MODULE_DESCRIPTION and MODULE_AUTHOR are also added.
>>
>> Signed-off-by: Jesse Chan <jc@...ux.com>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>>  net/9p/trans_xen.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c
>> index 325c56043007..336576f7e9f1 100644
>> --- a/net/9p/trans_xen.c
>> +++ b/net/9p/trans_xen.c
>> @@ -543,3 +543,7 @@ static void p9_trans_xen_exit(void)
>>       return xenbus_unregister_driver(&xen_9pfs_front_driver);
>>  }
>>  module_exit(p9_trans_xen_exit);
>> +
>> +MODULE_AUTHOR("Stefano Stabellini <stefano@...reto.com>");
>> +MODULE_DESCRIPTION("Xen Transport for 9P");
>> +MODULE_LICENSE("Dual MIT/GPL");
>
> Could you consider adding the credit to the people who are in this patch that addresses the same issue?
>
> https://patchwork.ozlabs.org/patch/856908/

Any version is fine with me, as long as the patch makes it in. I picked
up Jesse's patch and forwarded that one, as he seems to have been
the first person to send a patch back in November.

Comparing the two versions, I think that one is also better since it correctly
identifies the license as "Dual MIT/GPL", matching the comment.

        Arnd