netdev - Re: net: memory leak in socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0578c35c-43a7-ad5f-9cd9-c7ba5fde522f@cogentembedded.com>
Date:   Wed, 10 Jan 2018 12:30:05 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Al Viro <viro@...IV.linux.org.uk>,
        David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        syzkaller <syzkaller@...glegroups.com>,
        Dmitry Vyukov <dvyukov@...gle.com>
Subject: Re: net: memory leak in socket

Hello!

On 1/9/2018 11:53 PM, Al Viro wrote:

>>> Argh...  Got broken by "make sock_alloc_file() do sock_release() on failures" -
>>> cleanup after sock_map_fd() failure got pulled all the way into sock_alloc_file(),
>>> but it used to serve the case when sock_map_fd() failed *before* getting to
>>> sock_alloc_file().
>>>
>>> Fixes: commit 8e1611e23579 (make sock_alloc_file() do sock_release() on failures)
>>> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
>>
>> Please add:
>>
>> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> 
> Sure, no problem.  Dave, which tree should that go through?  Do you pick it, or
> should I send the below directly to Linus?
> ----
> Fix a leak in socket(2) when we fail to allocate a file descriptor.
> 
> Got broken by "make sock_alloc_file() do sock_release() on failures" -
> cleanup after sock_map_fd() failure got pulled all the way into
> sock_alloc_file(), but it used to serve the case when sock_map_fd()
> failed *before* getting to sock_alloc_file() as well, and that got
> lost.  Trivial to fix, fortunately.
> 
> Fixes: commit 8e1611e23579 (make sock_alloc_file() do sock_release() on failures)

Fixes: 8e1611e23579 ("make sock_alloc_file() do sock_release() on failures")

> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
[...]

MBR, Sergei