netdev - RE: [PATCH net-next 3/3] xfrm: Add ESN support for IPSec HW offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0502MB37580D23FFCB2DC80ECB0E28D5110@VI1PR0502MB3758.eurprd05.prod.outlook.com>
Date:   Wed, 10 Jan 2018 10:35:37 +0000
From:   Yossef Efraim <yossefe@...lanox.com>
To:     Steffen Klassert <steffen.klassert@...unet.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Boris Pismenny <borisp@...lanox.com>,
        "Yevgeny Kliteynik" <kliteyn@...lanox.com>,
        Yossi Kuperman <yossiku@...lanox.com>
Subject: RE: [PATCH net-next 3/3] xfrm: Add ESN support for IPSec HW offload

Ok 
Doc updated.
Sending this patch again with all the fixes.

Thanks!

> -----Original Message-----
> From: Steffen Klassert [mailto:steffen.klassert@...unet.com]
> Sent: Friday, December 01, 2017 8:23 AM
> To: Yossef Efraim <yossefe@...lanox.com>
> Cc: David S. Miller <davem@...emloft.net>; Herbert Xu
> <herbert@...dor.apana.org.au>; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; Boris Pismenny <borisp@...lanox.com>; Yevgeny
> Kliteynik <kliteyn@...lanox.com>; Yossi Kuperman <yossiku@...lanox.com>
> Subject: Re: [PATCH net-next 3/3] xfrm: Add ESN support for IPSec HW offload
> 
> On Tue, Nov 28, 2017 at 11:49:30AM +0200, yossefe@...lanox.com wrote:
> > From: Yossef Efraim <yossefe@...lanox.com>
> >
> > This patch adds ESN support to IPsec device offload.
> > Adding new xfrm device operation to synchronize device ESN.
> >
> > Signed-off-by: Yossef Efraim <yossefe@...lanox.com>
> > ---
> >  include/linux/netdevice.h |  1 +
> >  include/net/xfrm.h        | 12 ++++++++++++
> >  net/xfrm/xfrm_device.c    |  4 ++--
> >  net/xfrm/xfrm_replay.c    |  2 ++
> >  4 files changed, 17 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> > index 7de7656..d4e9198 100644
> > --- a/include/linux/netdevice.h
> > +++ b/include/linux/netdevice.h
> > @@ -825,6 +825,7 @@ struct xfrmdev_ops {
> >  	void	(*xdo_dev_state_free) (struct xfrm_state *x);
> >  	bool	(*xdo_dev_offload_ok) (struct sk_buff *skb,
> >  				       struct xfrm_state *x);
> > +	void	(*xdo_dev_state_advance_esn) (struct xfrm_state *x);
> 
> We now have a documentation for the xfrm offloadin API in the ipsec-next tree.
> Please document the new device operation there and resubmit.
> 
> Thanks!