netdev - RE: 4.15.0-rc6 unable to handle kernel NULL pointer dereference in ixgbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 11 Jan 2018 02:53:31 +0000
From:   wangyunjian <wangyunjian@...wei.com>
To:     "Tantilov, Emil S" <emil.s.tantilov@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
Subject: RE: 4.15.0-rc6 unable to handle kernel NULL pointer dereference in
 ixgbe_down

I excuted multiple script 1 and script 2 , and ran them for a long time .
The nic is Intel 82599. 

I think we should use a lock to protect adapter->vfinfo when disable sriov
and down nic.

> -----Original Message-----
> From: Tantilov, Emil S [mailto:emil.s.tantilov@...el.com]
> Sent: Wednesday, January 10, 2018 5:16 AM
> To: wangyunjian <wangyunjian@...wei.com>; netdev@...r.kernel.org; intel-
> wired-lan@...ts.osuosl.org
> Subject: RE: 4.15.0-rc6 unable to handle kernel NULL pointer dereference in
> ixgbe_down
> 
> >-----Original Message-----
> >From: netdev-owner@...r.kernel.org
> >[mailto:netdev-owner@...r.kernel.org]
> >On Behalf Of wangyunjian
> >Sent: Monday, January 08, 2018 1:31 AM
> >To: netdev@...r.kernel.org; intel-wired-lan@...ts.osuosl.org
> >Subject: BUG: 4.15.0-rc6 unable to handle kernel NULL pointer
> >dereference in ixgbe_down
> >
> >Hi,
> >
> >I'm running into a NULL pointer dereference in ixgbe_down on
> >b84449dc14d274a3f3c78cd734b702ca31aa4dd1
> >git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master.
> >
> >I think the variable adapter->vfinfo has not been protected well, when
> >disable sriov and down nic.
> >Anyone has an idea to protect it?
> >
> >Test script 1:
> >while true
> >do
> >    ifconfig eth3 up
> >    ifconfig eth3 down
> >done
> >
> >Test script 2:
> >while true
> >do
> >    echo 63 > /sys/class/net/eth3/device/sriov_numvfs
> >    echo 0 > /sys/class/net/eth3/device/sriov_numvfs
> >done
> 
> I ran this test on my system and also forwarded this report to our validation
> but we were not able to hit this crash. Does it crash fairly quickly, or do you
> need to run it for some time.
> 
> In ixgbe_down() I can see where there may be races due to the adapter-
> >num_vfs check. Ideally we should probably move to adapter->vfinfo checks
> only, but it would be nice to have a way to reproduce it for the purpose of
> testing fixes and debugging in general. Could you provide your .config file and
> additional information about your system - architecture, NIC type etc.
> 
> Thanks,
> Emil


Download attachment "ATT77341.config" of type "application/octet-stream" (190834 bytes)