netdev - Re: [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180112014216.396904f3@laptop>
Date:   Fri, 12 Jan 2018 01:42:16 -0800
From:   Jakub Kicinski <kubakici@...pl>
To:     Nogah Frankel <nogahf@...lanox.com>
Cc:     Yuval Mintz <yuvalm@...lanox.com>, Jiri Pirko <jiri@...nulli.us>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Ido Schimmel" <idosch@...lanox.com>, mlxsw <mlxsw@...lanox.com>,
        "jhs@...atatu.com" <jhs@...atatu.com>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>
Subject: Re: [patch net-next 3/5] net: sch: prio: Add offload ability to
 PRIO qdisc

On Fri, 12 Jan 2018 09:20:46 +0000
Nogah Frankel <nogahf@...lanox.com> wrote:

> > > > > Could we please pass the full qstats on replace and destroy.
> > > > > This simplifies the driver code and allows handling the qlen
> > > > > as well as backlog.  Please see the 2 patch series I sent
> > > > > earlier yesterday.  
> 
> On replace - no problem.
> On destroy, I think it is redundant because the qdisc is going to be
> deleted anyway.

Right, the hope was it wouldn't matter and could make the code easier
to follow, but the replace with new qdisc complicates things.

> (To make sure that we are on the same page, if replace in the HW
> fails, we "rollback" only the backlog and qlen. The rest of the
> counters like TX count should reflect the number of the packets that
> passed in the HW while this qdisc was offloaded)

Agreed!