netdev - Re: [PATCH net] sctp: avoid compiler warning on implicit fallthru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADvbK_d0haNUgUNYg9ggELGj-p+enVLA+iRzUZ7A1SJiGvBxcQ@mail.gmail.com>
Date:   Sat, 13 Jan 2018 12:48:36 +0800
From:   Xin Long <lucien.xin@...il.com>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        Neil Horman <nhorman@...driver.com>,
        Vlad Yasevich <vyasevich@...il.com>
Subject: Re: [PATCH net] sctp: avoid compiler warning on implicit fallthru

On Fri, Jan 12, 2018 at 12:22 AM, Marcelo Ricardo Leitner
<marcelo.leitner@...il.com> wrote:
> These fall-through are expected.
>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> ---
>  net/sctp/ipv6.c     | 1 +
>  net/sctp/outqueue.c | 4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
> index 3b18085e3b10253f3f81be7a6747b50ef9357db2..5d4c15bf66d26219415596598a1f72d29b63a798 100644
> --- a/net/sctp/ipv6.c
> +++ b/net/sctp/ipv6.c
> @@ -826,6 +826,7 @@ static int sctp_inet6_af_supported(sa_family_t family, struct sctp_sock *sp)
>         case AF_INET:
>                 if (!__ipv6_only_sock(sctp_opt2sk(sp)))
>                         return 1;
> +               /* fallthru */
>         default:
>                 return 0;
>         }
> diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c
> index 7d67feeeffc1e758ae4be4ef1ddaea23276d1f5e..c4ec99b2015002b273071e6fb1ec3c59c9f61154 100644
> --- a/net/sctp/outqueue.c
> +++ b/net/sctp/outqueue.c
> @@ -918,9 +918,9 @@ static void sctp_outq_flush(struct sctp_outq *q, int rtx_timeout, gfp_t gfp)
>                         break;
>
>                 case SCTP_CID_ABORT:
> -                       if (sctp_test_T_bit(chunk)) {
> +                       if (sctp_test_T_bit(chunk))
>                                 packet->vtag = asoc->c.my_vtag;
> -                       }
> +                       /* fallthru */
>                 /* The following chunks are "response" chunks, i.e.
>                  * they are generated in response to something we
>                  * received.  If we are sending these, then we can
> --
> 2.14.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reviewed-by: Xin Long <lucien.xin@...il.com>