netdev - [patch 1/1] net/ipv6/route.c: work around gcc-4.4.4 anon union initializer issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a595053.ZGoOkSYptXloCWEN%akpm@linux-foundation.org>
Date:   Fri, 12 Jan 2018 16:18:27 -0800
From:   akpm@...ux-foundation.org
To:     davem@...emloft.net, netdev@...r.kernel.org,
        akpm@...ux-foundation.org, dsahern@...il.com, idosch@...lanox.com
Subject: [patch 1/1] net/ipv6/route.c: work around gcc-4.4.4 anon union
 initializer issue

From: Andrew Morton <akpm@...ux-foundation.org>
Subject: net/ipv6/route.c: work around gcc-4.4.4 anon union initializer issue

gcc-4.4.4 has problems with initializers of anonymous union fields.

net/ipv6/route.c: In function 'rt6_sync_up':
net/ipv6/route.c:3586: error: unknown field 'nh_flags' specified in initializer
net/ipv6/route.c:3586: warning: missing braces around initializer
net/ipv6/route.c:3586: warning: (near initialization for 'arg.<anonymous>')
net/ipv6/route.c: In function 'rt6_sync_down_dev':
net/ipv6/route.c:3695: error: unknown field 'event' specified in initializer
net/ipv6/route.c:3695: warning: missing braces around initializer
net/ipv6/route.c:3695: warning: (near initialization for 'arg.<anonymous>')

Fixes: 2127d95aef6c ("ipv6: Clear nexthop flags upon netdev up")
Cc: Ido Schimmel <idosch@...lanox.com>
Cc: David Ahern <dsahern@...il.com>
Cc: David S. Miller <davem@...emloft.net>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
---

 net/ipv6/route.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff -puN net/ipv6/route.c~net-ipv6-routec-work-around-gcc-444-anon-union-initializer-issue net/ipv6/route.c
--- a/net/ipv6/route.c~net-ipv6-routec-work-around-gcc-444-anon-union-initializer-issue
+++ a/net/ipv6/route.c
@@ -3583,7 +3583,7 @@ void rt6_sync_up(struct net_device *dev,
 {
 	struct arg_netdev_event arg = {
 		.dev = dev,
-		.nh_flags = nh_flags,
+		{ .nh_flags = nh_flags, },
 	};
 
 	if (nh_flags & RTNH_F_DEAD && netif_carrier_ok(dev))
@@ -3692,7 +3692,7 @@ void rt6_sync_down_dev(struct net_device
 {
 	struct arg_netdev_event arg = {
 		.dev = dev,
-		.event = event,
+		{ .event = event, },
 	};
 
 	fib6_clean_all(dev_net(dev), fib6_ifdown, &arg);
_