netdev - Re: [PATCH net-next] net: dpaa: change while() to if() in dpaa_fq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1515835482.32366.11.camel@163.com>
Date:   Sat, 13 Jan 2018 17:24:42 +0800
From:   yuan linyu <cugyly@....com>
To:     netdev@...r.kernel.org
Cc:     "David S . Miller" <davem@...emloft.net>,
        yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>
Subject: Re: [PATCH net-next] net: dpaa: change while() to if() in
 dpaa_fq_setup()

i am wrong, ignore it.

On 六, 2018-01-13 at 17:15 +0800, yuan linyu wrote:
> From: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>
> 
> while loop is not needed, because list_for_each_entry() already check all fq.
> 
> Signed-off-by: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>
> ---
>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index 7caa8da..fd0e411 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -931,7 +931,7 @@ static void dpaa_fq_setup(struct dpaa_priv *priv,
>  	}
>  
>  	 /* Make sure all CPUs receive a corresponding Tx queue. */
> -	while (egress_cnt < DPAA_ETH_TXQ_NUM) {
> +	if (egress_cnt < DPAA_ETH_TXQ_NUM) {
>  		list_for_each_entry(fq, &priv->dpaa_fq_list, list) {
>  			if (fq->fq_type != FQ_TYPE_TX)
>  				continue;