netdev - Re: [PATCH net] ipv6: Fix cleanup ordering on inet6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpWO1iQTd6zWeWmxaOzHf==1dePsXjUZOSaKTcu4T6aH9g@mail.gmail.com>
Date:   Sat, 13 Jan 2018 09:39:23 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Ben Hutchings <ben.hutchings@...ethink.co.uk>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Andrey Konovalov <andreyknvl@...gle.com>
Subject: Re: [PATCH net] ipv6: Fix cleanup ordering on inet6_init() error path

On Tue, Jan 9, 2018 at 10:21 AM, Ben Hutchings
<ben.hutchings@...ethink.co.uk> wrote:
> Commit 15e668070a64 reordered the initialisation in inet6_init() to
> fix a crash on an error path further down the call stack.  It also
> reordered cleanup on the error path in inet6_init(), but the result
> is not the reverse of the initialisation order.  This presumably
> can result in a resource leak or crash in some error cases.  Reorder
> cleanup again to fix this.
>
> Fixes: 15e668070a64 ("ipv6: reorder icmpv6_init() and ip6_mr_init()")
> Signed-off-by: Ben Hutchings <ben.hutchings@...ethink.co.uk>

Acked-by: Cong Wang <xiyou.wangcong@...il.com>