netdev - Re: [net 02/11] net/mlx5: Fix get vector affinity helper function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d906349-112f-50e1-2122-f2e5815bae76@grimberg.me>
Date:   Sun, 14 Jan 2018 11:29:33 +0200
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Saeed Mahameed <saeedm@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, Qing Huang <qing.huang@...cle.com>
Subject: Re: [net 02/11] net/mlx5: Fix get vector affinity helper function

Hi Saeed,

> mlx5_get_vector_affinity used to call pci_irq_get_affinity and after
> reverting the patch that sets the device affinity via PCI_IRQ_AFFINITY
> API, calling pci_irq_get_affinity becomes useless and it breaks RDMA
> mlx5 users.  To fix this, this patch provides an alternative way to
> retrieve IRQ vector affinity using legacy IRQ API, following
> smp_affinity read procfs implementation.
> 
> Fixes: 231243c82793 ("Revert mlx5: move affinity hints assignments to generic code")
> Fixes: a435393acafb ("mlx5: move affinity hints assignments to generic code")
> Cc: Sagi Grimberg <sagi@...mberg.me>
> Cc: Qing Huang <qing.huang@...cle.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
I didn't have time to test it out thus far, I assume you tested it
though, so looks good to me,

Reviewed-by: Sagi Grimberg <sagi@...mberg.me>