netdev - Re: [PATCH bpf-next v2 07/15] bpf: offload: add map offload infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Jan 2018 00:37:15 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        alexei.starovoitov@...il.com, davem@...emloft.net
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com, tehnerd@...com
Subject: Re: [PATCH bpf-next v2 07/15] bpf: offload: add map offload
 infrastructure

Hi Jakub,

Series looks fine, just stumbled over one small thing here below.

On 01/12/2018 05:29 AM, Jakub Kicinski wrote:
[...]
> +bool bpf_offload_dev_match(struct bpf_prog *prog, struct bpf_map *map)
> +{
> +	struct bpf_offloaded_map *offmap;
> +	struct bpf_prog_offload *offload;
> +	bool ret;
> +
> +	if (!!bpf_prog_is_dev_bound(prog->aux) != !!bpf_map_is_dev_bound(map))
> +		return false;
> +	if (!bpf_prog_is_dev_bound(prog->aux))
> +		return true;

Should this not say 'false' if the prog has no offload_requested ...

> +	down_read(&bpf_devs_lock);
> +	offload = prog->aux->offload;
> +	offmap = map_to_offmap(map);
> +
> +	ret = offload && offload->netdev == offmap->netdev;

... meaning we return true from bpf_offload_dev_match() only in the
case when netdevs match?

> +	up_read(&bpf_devs_lock);
> +
> +	return ret;
> +}
Thanks,
Daniel