netdev - Re: [PATCH v6 02/36] openrisc: add ioremap_nocache declaration before include asm-generic/io.h and sync ioremap prototype with it.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180115130728.GG13019@lianli.shorne-pla.net>
Date:   Mon, 15 Jan 2018 22:07:28 +0900
From:   Stafford Horne <shorne@...il.com>
To:     Greentime Hu <green.hu@...il.com>
Cc:     greentime@...estech.com, linux-kernel@...r.kernel.org,
        arnd@...db.de, linux-arch@...r.kernel.org, tglx@...utronix.de,
        jason@...edaemon.net, marc.zyngier@....com, robh+dt@...nel.org,
        netdev@...r.kernel.org, deanbo422@...il.com,
        devicetree@...r.kernel.org, viro@...iv.linux.org.uk,
        dhowells@...hat.com, will.deacon@....com,
        daniel.lezcano@...aro.org, linux-serial@...r.kernel.org,
        geert.uytterhoeven@...il.com, linus.walleij@...aro.org,
        mark.rutland@....com, greg@...ah.com, ren_guo@...ky.com,
        rdunlap@...radead.org, davem@...emloft.net, jonas@...thpole.se,
        stefan.kristiansson@...nalahti.fi
Subject: Re: [PATCH v6 02/36] openrisc: add ioremap_nocache declaration
 before include asm-generic/io.h and sync ioremap prototype with it.

On Mon, Jan 15, 2018 at 01:53:10PM +0800, Greentime Hu wrote:
> From: Greentime Hu <greentime@...estech.com>
> 
> It will be built failed if commit id: d25ea659 is selected. This patch can fix this
> build error.

Hello,

As I mentioned last time, can you you change this to not mention the commit id?
The ID will probably change when this is actually committed.  You might want to
do something like:

 1. Move this commit before the ioremap_nocache change.  This is because we want
 each commit to result in a buildable kernel.

 2. The text here and other changes could read:

 A future commit for the nds32 architecture bootstrap ("asm-generic/io.h: move
 ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_wt out of ifndef CONFIG_MMU")
 will move the ioremap_nocache out of the CONFIG_MMU ifdef.  This means that
 in order to suppress re-definition errors we need to setup #define's before
 importing asm-generic/io.h.

 Also, the change adds a prototype for ioremap where size is size_t so fix that
 as well.

I hope that helps. But for the change:

Acked-by: Stafford Horne <shorne@...il.com>

> Signed-off-by: Greentime Hu <greentime@...estech.com>
> ---
>  arch/openrisc/include/asm/io.h |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/openrisc/include/asm/io.h b/arch/openrisc/include/asm/io.h
> index 7c69139..6709b28 100644
> --- a/arch/openrisc/include/asm/io.h
> +++ b/arch/openrisc/include/asm/io.h
> @@ -29,13 +29,14 @@
>  #define PIO_OFFSET		0
>  #define PIO_MASK		0
>  
> +#define ioremap_nocache ioremap_nocache
>  #include <asm-generic/io.h>
>  #include <asm/pgtable.h>
>  
>  extern void __iomem *__ioremap(phys_addr_t offset, unsigned long size,
>  				pgprot_t prot);
>  
> -static inline void __iomem *ioremap(phys_addr_t offset, unsigned long size)
> +static inline void __iomem *ioremap(phys_addr_t offset, size_t size)
>  {
>  	return __ioremap(offset, size, PAGE_KERNEL);
>  }
> -- 
> 1.7.9.5
>