netdev - Re: [patch iproute2 v10 0/2] tc: Add batchsize feature to batch mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <680aeeb2-b151-c746-bb3b-502491908373@gmail.com>
Date:   Mon, 15 Jan 2018 09:40:39 -0700
From:   David Ahern <dsahern@...il.com>
To:     Chris Mi <chrism@...lanox.com>, netdev@...r.kernel.org
Cc:     gerlitz.or@...il.com, stephen@...workplumber.org,
        marcelo.leitner@...il.com, phil@....cc
Subject: Re: [patch iproute2 v10 0/2] tc: Add batchsize feature to batch mode

On 1/11/18 10:13 PM, Chris Mi wrote:
> Currently in tc batch mode, only one command is read from the batch
> file and sent to kernel to process. With this patchset, at most 128
> commands can be accumulated before sending to kernel.
> 
> We introduced a new function in patch 1 to support for sending
> multiple messages. In patch 2, we add this support for filter
> add/delete/change/replace and actions add/change/replace commands.
> 
> But please note that kernel still processes the requests one by one.
> To process the requests in parallel in kernel is another effort.
> The time we're saving in this patchset is the user mode and kernel mode
> context switch. So this patchset works on top of the current kernel.
> 
> Using the following script in kernel, we can generate 1,000,000 rules.
> 	tools/testing/selftests/tc-testing/tdc_batch.py
> 
> Without this patchset, 'tc -b $file' exection time is:
> 
> real    0m15.555s
> user    0m7.211s
> sys     0m8.284s
> 
> With this patchset, 'tc -b $file' exection time is:
> 
> real    0m12.360s
> user    0m6.082s
> sys     0m6.213s
> 
> The insertion rate is improved more than 10%.

LGTM. Applied to iproute2-next.