[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1516040009.2762.2.camel@arista.com>
Date: Mon, 15 Jan 2018 18:13:29 +0000
From: Dmitry Safonov <dima@...sta.com>
To: David Miller <davem@...emloft.net>
Cc: linux-kernel@...r.kernel.org, 0x7f454c46@...il.com, arnd@...db.de,
dwindsor@...il.com, edumazet@...gle.com, mingo@...nel.org,
johannes.berg@...el.com, mark.rutland@....com, rrendec@...sta.com,
elena.reshetova@...el.com, netdev@...r.kernel.org
Subject: Re: [PATCH 3/5] pktgen: Add behavior flag names array -
pkt_flag_names
On Mon, 2018-01-15 at 13:09 -0500, David Miller wrote:
> From: Dmitry Safonov <dima@...sta.com>
> Date: Tue, 9 Jan 2018 13:55:33 +0000
>
> > +#define pf(flag) __stringify(flag),
> > +char *pkt_flag_names[] = {
> > + PKT_FLAGS
> > +};
> > +#undef pf
>
> This should be static, also you don't use this table in this patch.
> You
> should add the table in the patch that actually uses the table.
Sure, will do.
--
Thanks,
Dmitry
Powered by blists - more mailing lists