netdev - Re: [PATCH v2 net-next 3/5] l2tp: remove l2specific_len dependency in l2tp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180115182000.GB1422@alphalink.fr>
Date:   Mon, 15 Jan 2018 19:20:00 +0100
From:   Guillaume Nault <g.nault@...halink.fr>
To:     Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, jchapman@...alix.com
Subject: Re: [PATCH v2 net-next 3/5] l2tp: remove l2specific_len dependency
 in l2tp_core

On Sun, Jan 14, 2018 at 03:50:56PM +0100, Lorenzo Bianconi wrote:
> --- a/net/l2tp/l2tp_core.h
> +++ b/net/l2tp/l2tp_core.h
> @@ -302,6 +302,17 @@ static inline void l2tp_session_dec_refcount(struct l2tp_session *session)
>  		l2tp_session_free(session);
>  }
>  
> +static inline int l2tp_get_l2specific_len(struct l2tp_session *session)
> +{
> +	switch (session->l2specific_type) {
> +	case L2TP_L2SPECTYPE_NONE:
> +		return 0;
> +	case L2TP_L2SPECTYPE_DEFAULT:
> +	default:
> +		return 4;
> +	}
> +}
> 
The data path only compares ->l2specific_type to L2SPECTYPE_DEFAULT and
treats any other value as L2SPECTYPE_NONE. Therefore, we should keep
this logic here and return 0 for unknown types.