netdev - Re: [PATCH net] netlink: extack needs to be reset each time through loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180115.135031.2251496604167847341.davem@davemloft.net>
Date:   Mon, 15 Jan 2018 13:50:31 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     netdev@...r.kernel.org, johannes.berg@...el.com
Subject: Re: [PATCH net] netlink: extack needs to be reset each time
 through loop

From: David Ahern <dsahern@...il.com>
Date: Wed, 10 Jan 2018 13:00:39 -0800

> syzbot triggered the WARN_ON in netlink_ack testing the bad_attr value.
> The problem is that netlink_rcv_skb loops over the skb repeatedly invoking
> the callback and without resetting the extack leaving potentially stale
> data. Initializing each time through avoids the WARN_ON.
> 
> Fixes: 2d4bc93368f5a ("netlink: extended ACK reporting")
> Reported-by: syzbot+315fa6766d0f7c359327@...kaller.appspotmail.com
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied and queued up for -stable, thanks David.