netdev - Re: [PATCH] usbnet: silence an unnecessary warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 15 Jan 2018 13:55:44 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     oneukum@...e.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] usbnet: silence an unnecessary warning

From: Oliver Neukum <oneukum@...e.com>
Date: Thu, 11 Jan 2018 16:01:49 +0100

> That a kevent could not be scheduled is not an error.
> Such handlers must be able to deal with multiple events anyway.
> As the successful scheduling of a work is a debug event, make
> the failure debug priority, too.
> 
> Signed-off-by: Oliver Neukum <oneukum@...e.com>
> Reported-by: Cristian Caravena <caravena@...il.com>
> ---
>  drivers/net/usb/usbnet.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index d56fe32bf48d..1e0bbe23f95c 100644
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -458,8 +458,7 @@ void usbnet_defer_kevent (struct usbnet *dev, int work)
>  {
>  	set_bit (work, &dev->flags);
>  	if (!schedule_work (&dev->kevent)) {
> -		if (net_ratelimit())
> -			netdev_err(dev->net, "kevent %d may have been dropped\n", work);
> +		netdev_dbg(dev->net, "kevent %d may have been dropped\n", work);
>  	} else {
>  		netdev_dbg(dev->net, "kevent %d scheduled\n", work);
>  	}

As Bjørn stated, you have to clean up the braces since both arms of the
conditional are now a single line and therefore should not get curly
braces.

Thank you.